Horton

Re: [HACKERS] Custom compression methods

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, David Steele <david@pgmasters.net>, Ildus Kurbangaliev <i.kurbangaliev@gmail.com>, Dmitry Dolgov <9erthalion6@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2021-02-14T20:28:31Z
Lists: pgsql-hackers

Attachments

On Sun, Feb 14, 2021 at 12:49:40PM -0600, Justin Pryzby wrote:
> On Wed, Feb 10, 2021 at 04:56:17PM -0500, Robert Haas wrote:
> > Small delta patch with a few other suggested changes attached.
> 
> Robert's fixup patch caused the CI to fail, since it 1) was called *.patch;
> and, 2) didn't include the previous patches.
> 
> This includes a couple proposals of mine as separate patches.

CIs failed on BSD and linux due to a test in contrib/, but others passed.
https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.127551
https://cirrus-ci.com/task/6087701947482112
https://cirrus-ci.com/task/6650651900903424
https://cirrus-ci.com/task/5524751994060800

Resending with fixes to configure.ac and missed autoconf run.  I think this is
expected to fail on mac, due to missing LZ4.

BTW, compressamapi.h doesn't need to be included in any of these, at least in
the 0001 patch:

 src/backend/access/common/indextuple.c | 2 +-
 src/backend/catalog/heap.c             | 2 +-
 src/backend/catalog/index.c            | 2 +-
 src/backend/parser/parse_utilcmd.c     | 2 +-

It's pretty unfriendly that this requires quoting the integer to be
syntactically valid:

|postgres=# create table j(q text compression pglz with (level 1) );
|2021-01-30 01:26:33.554 CST [31814] ERROR:  syntax error at or near "1" at character 52
|2021-01-30 01:26:33.554 CST [31814] STATEMENT:  create table j(q text compression pglz with (level 1) );
|ERROR:  syntax error at or near "1"
|LINE 1: create table j(q text compression pglz with (level 1) );

Commits

  1. docs: Update TOAST storage docs for configurable compression.

  2. Further tweaking of pg_dump's handling of default_toast_compression.

  3. Fix interaction of TOAST compression with expression indexes.

  4. Tidy up more loose ends related to configurable TOAST compression.

  5. Short-circuit slice requests that are for more than the object's size.

  6. Mostly-cosmetic adjustments of TOAST-related macros.

  7. Remove useless configure probe for <lz4/lz4.h>.

  8. Error on invalid TOAST compression in CREATE or ALTER TABLE.

  9. docs: Fix omissions related to configurable TOAST compression.

  10. More code cleanup for configurable TOAST compression.

  11. Bring configure support for LZ4 up to snuff.

  12. Make compression.sql regression test independent of default.

  13. Use valid compression method in brin_form_tuple

  14. Fix up pg_dump's handling of per-attribute compression options.

  15. Allow configurable LZ4 TOAST compression.

  16. Fix inconsistencies in the code

  17. Mostly-cosmetic improvements in memory chunk header alignment coding.

  18. Allow numeric to use a more compact, 2-byte header in many cases.