Re: [HACKERS] Custom compression methods

Justin Pryzby <pryzby@telsasoft.com>

From: Justin Pryzby <pryzby@telsasoft.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, David Steele <david@pgmasters.net>, Ildus Kurbangaliev <i.kurbangaliev@gmail.com>, Dmitry Dolgov <9erthalion6@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2021-02-14T18:49:40Z
Lists: pgsql-hackers

Attachments

On Wed, Feb 10, 2021 at 04:56:17PM -0500, Robert Haas wrote:
> Small delta patch with a few other suggested changes attached.

Robert's fixup patch caused the CI to fail, since it 1) was called *.patch;
and, 2) didn't include the previous patches.

This includes a couple proposals of mine as separate patches.

 . psql: Add HIDE_COMPRESSAM for regress testing; I'm proposing this as part of
   0001 (I excluded the reression test changes from 0001 which would've been
   reverted by this patch).
 . Add default_toast_compression GUC with ideas from Robert; I'm proposing
   something like this as part of 0001.  Actually, the full complexity with syscache
   lookups and invalidation aren't needed in 0001, but are needed in the 
   "Custom compression" patch.
 . default --enable-lz4 (this not meant to be merged so you could leave this as
   a separate patch)

I'm not including the whole patch series, since this patch is failing
pg_restore tests:
|Create custom compression methods

-- 
Justin

Commits

  1. docs: Update TOAST storage docs for configurable compression.

  2. Further tweaking of pg_dump's handling of default_toast_compression.

  3. Fix interaction of TOAST compression with expression indexes.

  4. Tidy up more loose ends related to configurable TOAST compression.

  5. Short-circuit slice requests that are for more than the object's size.

  6. Mostly-cosmetic adjustments of TOAST-related macros.

  7. Remove useless configure probe for <lz4/lz4.h>.

  8. Error on invalid TOAST compression in CREATE or ALTER TABLE.

  9. docs: Fix omissions related to configurable TOAST compression.

  10. More code cleanup for configurable TOAST compression.

  11. Bring configure support for LZ4 up to snuff.

  12. Make compression.sql regression test independent of default.

  13. Use valid compression method in brin_form_tuple

  14. Fix up pg_dump's handling of per-attribute compression options.

  15. Allow configurable LZ4 TOAST compression.

  16. Fix inconsistencies in the code

  17. Mostly-cosmetic improvements in memory chunk header alignment coding.

  18. Allow numeric to use a more compact, 2-byte header in many cases.