Horton

Re: libpq debug log

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: 'Alvaro Herrera' <alvherre@alvh.no-ip.org>
To: "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>
Cc: "iwata.aya@fujitsu.com" <iwata.aya@fujitsu.com>, "k.jamison@fujitsu.com" <k.jamison@fujitsu.com>, "'pgsql-hackers@lists.postgresql.org'" <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-09T10:47:43Z
Lists: pgsql-hackers 
On 2021-Feb-04, tsunakawa.takay@fujitsu.com wrote:

> From: 'Alvaro Herrera' <alvherre@alvh.no-ip.org>
> > > (41)
> > > +void
> > > +PQtraceEx(PGconn *conn, FILE *debug_port, int flags)
> > > +{
> > 
> > I'm not really sure about making this a separate API call. We could just
> > make it PQtrace() and increment the libpq so version.  I don't think
> > it's a big deal, frankly.
> 
> If we change the function signature, we have to bump the so major version and thus soname.  The libpq's current so major version is 5, which hasn't been changed since 2006.  I'm hesitant to change it for this feature.  If you think we can bump the version to 6, I think we can go.

I think it's pretty clear we would not change the so-version for this
feature.


-- 
Álvaro Herrera                            39°49'30"S 73°17'W

Commits

  1. Rename PQtraceSetFlags() to PQsetTraceFlags().

  2. Suppress length of Notice/Error msgs in PQtrace regress mode

  3. Strip file names reported in error messages on Windows, too.

  4. Fix setvbuf()-induced crash in libpq_pipeline

  5. libpq_pipeline: Must strdup(optarg) to avoid crash

  6. Remove setvbuf() call from PQtrace()

  7. Initialize conn->Pfdebug to NULL when creating a connection

  8. Disable force_parallel_mode in libpq_pipeline

  9. libpq_pipeline: add PQtrace() support and tests

  10. Improve PQtrace() output format

  11. Re-simplify management of inStart in pqParseInput3's subroutines.