Re: GlobalVisIsRemovableFullXid() vs GlobalVisCheckRemovableXid()

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-07T03:40:24Z
Lists: pgsql-hackers
Hi,

On 2021-02-06 12:27:30 -0800, Peter Geoghegan wrote:
> Why is GlobalVisIsRemovableFullXid() not named
> GlobalVisCheckRemovableFullXid() instead? ISTM that that name makes
> much more sense, since it is what I'd expect for a function that is
> the "Full XID equivalent" of GlobalVisCheckRemovableXid().
> 
> Note also that GlobalVisIsRemovableFullXid() is the only symbol name
> matching "GlobalVisIsRemovable*".

Looks like a mistake on my part... Probably a rename regex that somehow
went wrong - I went back and forth on those names way too many
times. Want me to push the fix?

Greetings,

Andres Freund



Commits

  1. ReadNewTransactionId() -> ReadNextTransactionId().

  2. Rename removable xid function for consistency.

  3. Add basic infrastructure for 64 bit transaction IDs.