Horton

Re: [HACKERS] Custom compression methods

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, David Steele <david@pgmasters.net>, Ildus Kurbangaliev <i.kurbangaliev@gmail.com>, Dmitry Dolgov <9erthalion6@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2021-02-05T17:41:19Z
Lists: pgsql-hackers 
This fails make-check world for me, and CFBOT will say the same.
Be sure to compile with --enable-tap-tests

cd . && TESTDIR='/home/pryzbyj/src/postgres/src/bin/pg_dump' PATH="/home/pryzbyj/src/postgres/tmp_install/usr/local/pgsql/bin:$PATH" LD_LIBRARY_PATH="/home/pryzbyj/src/postgres/tmp_install/usr/local/pgsql/lib"  PGPORT='65432' PG_REGRESS='/home/pryzbyj/src/postgres/src/bin/pg_dump/../../../src/test/regress/pg_regress' REGRESS_SHLIB='/home/pryzbyj/src/postgres/src/test/regress/regress.so' /usr/bin/prove -I ../../../src/test/perl/ -I .  t/*.pl
t/001_basic.pl ................ ok
t/002_pg_dump.pl .............. 13/6408
#   Failed test 'binary_upgrade: should dump CREATE TABLE test_fifth_table'
#   at t/002_pg_dump.pl line 3601.
# Review binary_upgrade results in /home/pryzbyj/src/postgres/src/bin/pg_dump/tmp_check/tmp_test_gw4p

#   Failed test 'binary_upgrade: should dump CREATE TABLE test_second_table'
#   at t/002_pg_dump.pl line 3601.
# Review binary_upgrade results in /home/pryzbyj/src/postgres/src/bin/pg_dump/tmp_check/tmp_test_gw4p

#   Failed test 'binary_upgrade: should dump CREATE TABLE test_table'
#   at t/002_pg_dump.pl line 3601.
# Review binary_upgrade results in /home/pryzbyj/src/postgres/src/bin/pg_dump/tmp_check/tmp_test_gw4p

#   Failed test 'binary_upgrade: should dump CREATE TABLE test_table_identity'
#   at t/002_pg_dump.pl line 3601.
# Review binary_upgrade results in /home/pryzbyj/src/postgres/src/bin/pg_dump/tmp_check/tmp_test_gw4p
t/002_pg_dump.pl .............. 6203/6408 # Looks like you failed 4 tests of 6408.
t/002_pg_dump.pl .............. Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/6408 subtests

Commits

  1. docs: Update TOAST storage docs for configurable compression.

  2. Further tweaking of pg_dump's handling of default_toast_compression.

  3. Fix interaction of TOAST compression with expression indexes.

  4. Tidy up more loose ends related to configurable TOAST compression.

  5. Short-circuit slice requests that are for more than the object's size.

  6. Mostly-cosmetic adjustments of TOAST-related macros.

  7. Remove useless configure probe for <lz4/lz4.h>.

  8. Error on invalid TOAST compression in CREATE or ALTER TABLE.

  9. docs: Fix omissions related to configurable TOAST compression.

  10. More code cleanup for configurable TOAST compression.

  11. Bring configure support for LZ4 up to snuff.

  12. Make compression.sql regression test independent of default.

  13. Use valid compression method in brin_form_tuple

  14. Fix up pg_dump's handling of per-attribute compression options.

  15. Allow configurable LZ4 TOAST compression.

  16. Fix inconsistencies in the code

  17. Mostly-cosmetic improvements in memory chunk header alignment coding.

  18. Allow numeric to use a more compact, 2-byte header in many cases.