Horton

Re: Snapbuild woes followup

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Petr Jelinek <petr@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@gmail.com>
Date: 2021-01-25T20:48:13Z
Lists: pgsql-hackers

Attachments

Hi,

On 2021-01-25 12:00:08 -0800, Andres Freund wrote:
> > > 	/*
> > > 	 * For backward compatibility reasons this has to be stored in the wrongly
> > > 	 * named field.  Will be fixed in next major version.
> > > 	 */
> > > 	return builder->was_running.was_xmax;
> >
> > We could fix that now... Andres, what did you have in mind for a proper
> > name?
> 
> next_phase_at seems like it'd do the trick?

See attached patch...

Commits

  1. Remove backwards compat ugliness in snapbuild.c.

  2. Fix two typos in snapbuild.c.

  3. Fix race condition leading to hanging logical slot creation.