Re: Printing LSN made easy
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: michael@paquier.xyz
Cc: peter.eisentraut@2ndquadrant.com, ashutosh.bapat.oss@gmail.com,
pgsql-hackers@postgresql.org, ashutosh.bapat@enterprisedb.com,
craig.ringer@enterprisedb.com
Date: 2021-01-21T00:29:59Z
Lists: pgsql-hackers
At Wed, 20 Jan 2021 16:40:59 +0900, Michael Paquier <michael@paquier.xyz> wrote in > On Wed, Jan 20, 2021 at 07:25:37AM +0100, Peter Eisentraut wrote: > > It looks like we are not getting any consensus on this approach. One > > reduced version I would consider is just the second part, so you'd write > > something like > > > > snprintf(lsnchar, sizeof(lsnchar), "%X/%X", > > LSN_FORMAT_ARGS(lsn)); > > > > This would still reduce notational complexity quite a bit but avoid any > > funny business with the format strings. > > That seems reasonable to me. So +1. That seems in the good balance. +1, too. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Simplify printing of LSNs
- 6f6f284c7ee4 14.0 landed
-
Unwind some workarounds for lack of portable int64 format specifier
- 6a1cd8b9236d 13.0 cited