Re: Odd, intermittent failure in contrib/pageinspect

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>, pgsql-hackers@lists.postgresql.org
Date: 2021-01-20T01:50:06Z
Lists: pgsql-hackers
Hi,

On 2021-01-18 19:40:05 -0300, Alvaro Herrera wrote:
> > [ thinks for a bit... ]  Does the checkpointer pin pages it's writing
> > out?  I guess it'd have to ...
> 
> It does, per SyncOneBuffer(), called from BufferSync(), called from
> CheckPointBuffers().

I think you don't event need checkpointer to be involved, normal buffer
replacement would do the trick. We briefly pin the page in BufferAlloc()
even if the page is clean. Longer when it's dirty, of course.

Greetings,

Andres Freund



Commits

  1. Disable vacuum page skipping in selected test cases.