Horton

pg_dump vs. GRANT OPTION among initial privileges

Noah Misch <noah@leadboat.com>

View thread View on postgr.es
From: Noah Misch <noah@leadboat.com>
To: pgsql-hackers@postgresql.org
Date: 2021-01-09T10:24:23Z
Lists: pgsql-hackers

Attachments

pg_dump can generate invalid SQL syntax if an aclitem in pg_init_privs
contains a GRANT OPTION (an asterisk in the aclitemout() representation).
Also, pg_dump uses REVOKE GRANT OPTION FOR where it needs plain REVOKE.  For
more details, see the log message in the attached patch.  I recommend
reviewing "diff -w" output first.  I'm not certain the test suite will always
find those REVOKE statements in the same order; if that order varies, one
regex will need more help.

Commits

  1. Fix pg_dump for GRANT OPTION among initial privileges.