should frontend tools use syncfs() ?

Justin Pryzby <pryzby@telsasoft.com>

From: Justin Pryzby <pryzby@telsasoft.com>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: David Steele <david@pgmasters.net>, Fujii Masao <masao.fujii@oss.nttdata.com>, Bruce Momjian <bruce@momjian.us>, Paul Guo <guopa@vmware.com>, Tom Lane <tgl@sss.pgh.pa.us>, Michael Brown <michael.brown@discourse.org>, pgsql-hackers <pgsql-hackers@postgresql.org>, Michael Paquier <michael@paquier.xyz>

Date: 2021-09-30T00:43:41Z

Lists: pgsql-hackers

Attachments

0001-Allow-use-of-syncfs-in-frontend-tools.patch (text/x-diff)

Forking this thread in which Thomas implemented syncfs for the startup process
(61752afb2).
https://www.postgresql.org/message-id/flat/CA%2BhUKG%2BSG9jSW3ekwib0cSdC0yD-jReJ21X4bZAmqxoWTLTc2A%40mail.gmail.com

Is there any reason that initdb/pg_basebackup/pg_checksums/pg_rewind shouldn't
use syncfs()  ?

do_syncfs() is in src/backend/ so would need to be duplicated^Wimplemented in
common.

They can't use the GUC, so need to add an cmdline option or look at an
environment variable.

Commits

Adjust documentation for syncfs().
- 44a4cca9913b 17.0 landed
Improve the naming in wal_sync_method code.
- 8d140c58229d 17.0 landed
Allow using syncfs() in frontend utilities.
- 8c16ad3b4329 17.0 landed
Add support for syncfs() in frontend support functions.
- cccc6cdeb32f 17.0 landed
Make enum for sync methods available to frontend code.
- 3ed19567198d 17.0 landed
Move PG_TEMP_FILE* macros to file_utils.h.
- f39b265808bd 17.0 landed
Change client-side fsync_fname() to report errors fatally
- 1420617b14e2 13.0 cited