Horton

Thread

Commits

  1. Clarify use of "statistics objects" in the code

  2. Fix typos and grammar in code comments

  3. Fix typos in docs

  1. typos

    Justin Pryzby <pryzby@telsasoft.com> — 2021-09-24T21:58:27Z

    A compilation of fixes for master.

The first patch should be applied to v13 - the typo was already fixed in master
but not backpatched.

  2. Re: typos (and more)

    Justin Pryzby <pryzby@telsasoft.com> — 2021-09-26T17:01:17Z

    On Fri, Sep 24, 2021 at 04:58:27PM -0500, Justin Pryzby wrote:
> A compilation of fixes for master.

Thanks Michael for applying fixes to user-facing docs (I hadn't realized that
the 2nd one needed to be backpatched).

This fixes an file I failed to include in the "recheck" patch and more typos
for extended stats (+Tomas).

+Andres (Jit), +Zhihong (file header comments).

  3. Re: typos (and more)

    Michael Paquier <michael@paquier.xyz> — 2021-09-27T00:24:27Z

    On Sun, Sep 26, 2021 at 12:01:17PM -0500, Justin Pryzby wrote:
> Thanks Michael for applying fixes to user-facing docs (I hadn't realized that
> the 2nd one needed to be backpatched).

Yes, thanks for compiling all these.  The two changes committed were
the only user-visible changes, which is why I have hastened this part
to include those fixes.  The rest could just go on HEAD.
--
Michael

  4. Re: typos (and more)

    Michael Paquier <michael@paquier.xyz> — 2021-09-27T05:23:50Z

    On Mon, Sep 27, 2021 at 09:24:27AM +0900, Michael Paquier wrote:
> Yes, thanks for compiling all these.  The two changes committed were
> the only user-visible changes, which is why I have hastened this part
> to include those fixes.  The rest could just go on HEAD.

I have looked at the full set, and applied 0003, 0006, 0009, 0010 and
0011.  0001 has been discussed separately, and I am really not sure if
that's worth bothering.  0002 may actually break some code?  I have
let 0004 and 0005 alone.  0007 could be related to the discussion
where we could just remove all those IDENTIFICATION fields.  The use
of "statistic", "statistics" and "statistics object" in 0008 and 0012
is indeed inconsistent.  The latter term is the most used, but it
sounds a bit weird to me even if it refers to the DDL object
manipulated.  Simply using "statistics" would be tempting.
--
Michael

  5. Re: typos (and more)

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2021-09-27T21:04:02Z

    On 2021-Sep-27, Michael Paquier wrote:

> The use
> of "statistic", "statistics" and "statistics object" in 0008 and 0012
> is indeed inconsistent.  The latter term is the most used, but it
> sounds a bit weird to me even if it refers to the DDL object
> manipulated.  Simply using "statistics" would be tempting.

Initially we just used "statistic" as a noun, which IIRC was already
grammatically wrong (but I didn't know that and I think Tomas didn't
either); later at some point when discussing how to use that noun in
plural we realized this and argued that merely using "statistics" was
even more wrong.  It was then that we started using the term "statistics
object" with plural "statistics objects".  Going back to using just
"statistics" is unlikely to have become correct; I think Justin's
patches 0008 and 0012 are correct.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)

  6. Re: typos (and more)

    Michael Paquier <michael@paquier.xyz> — 2021-09-27T23:53:35Z

    On Mon, Sep 27, 2021 at 06:04:02PM -0300, Alvaro Herrera wrote:
> Initially we just used "statistic" as a noun, which IIRC was already
> grammatically wrong (but I didn't know that and I think Tomas didn't
> either); later at some point when discussing how to use that noun in
> plural we realized this and argued that merely using "statistics" was
> even more wrong.  It was then that we started using the term "statistics
> object" with plural "statistics objects".  Going back to using just
> "statistics" is unlikely to have become correct; I think Justin's
> patches 0008 and 0012 are correct.

Thanks for confirming.

     if (list_length(pstate->p_rtable) != 1)
         ereport(ERROR,
                 (errcode(ERRCODE_INVALID_COLUMN_REFERENCE),
-                 errmsg("statistics expressions can refer only to the table being indexed")));
+                 errmsg("statistics expressions can refer only to the table being referenced")));
This part should be backpatched?  The code claims that this should
be dead code so an elog() would be more adapted, and the same can be
said about transformRuleStmt() and transformIndexStmt(), no?  That
would be less messages to translate. 
--
Michael

  7. Re: typos (and more)

    Justin Pryzby <pryzby@telsasoft.com> — 2021-09-28T00:50:02Z

    On Mon, Sep 27, 2021 at 06:04:02PM -0300, Alvaro Herrera wrote:
> On 2021-Sep-27, Michael Paquier wrote:
> 
> > The use
> > of "statistic", "statistics" and "statistics object" in 0008 and 0012
> > is indeed inconsistent.  The latter term is the most used, but it
> > sounds a bit weird to me even if it refers to the DDL object
> > manipulated.  Simply using "statistics" would be tempting.
> 
> Initially we just used "statistic" as a noun, which IIRC was already
> grammatically wrong (but I didn't know that and I think Tomas didn't
> either); later at some point when discussing how to use that noun in
> plural we realized this and argued that merely using "statistics" was
> even more wrong.  It was then that we started using the term "statistics
> object" with plural "statistics objects".  Going back to using just
> "statistics" is unlikely to have become correct; I think Justin's
> patches 0008 and 0012 are correct.

Attached is an updated patch fixing more of the same.

-- 
Justin

  8. Re: typos (and more)

    Michael Paquier <michael@paquier.xyz> — 2021-09-28T02:15:39Z

    On Mon, Sep 27, 2021 at 07:50:02PM -0500, Justin Pryzby wrote:
> Attached is an updated patch fixing more of the same.

Does this include everything you have spotted, as well as everything
from the previous patches 0008 and 0012 posted?
--
Michael

  9. Re: typos (and more)

    Justin Pryzby <pryzby@telsasoft.com> — 2021-09-28T02:27:56Z

    On Tue, Sep 28, 2021 at 11:15:39AM +0900, Michael Paquier wrote:
> On Mon, Sep 27, 2021 at 07:50:02PM -0500, Justin Pryzby wrote:
> > Attached is an updated patch fixing more of the same.
> 
> Does this include everything you have spotted, as well as everything
> from the previous patches 0008 and 0012 posted?

That's an "expanded" version of 0008.

It doesn't include 0012, which is primarily about fixing incorrect references
to "index expressions" that should refer to stats expressions.  Naturally 0012
also uses the phrase "statistics objects", and fixes one nearby reference
that's not itself about indexes, which could arguably be in 0008 instead..

-- 
Justin

  10. Re: typos (and more)

    Michael Paquier <michael@paquier.xyz> — 2021-09-29T07:26:59Z

    On Mon, Sep 27, 2021 at 09:27:56PM -0500, Justin Pryzby wrote:
> That's an "expanded" version of 0008.

Okay, thanks.

> It doesn't include 0012, which is primarily about fixing incorrect references
> to "index expressions" that should refer to stats expressions.  Naturally 0012
> also uses the phrase "statistics objects", and fixes one nearby reference
> that's not itself about indexes, which could arguably be in 0008 instead..

Merging both made the most sense to me after reviewing the whole area
of the code dedicated to stats.  This has been applied after taking
care of some issues with the indentation, with few extra tweaks.
--
Michael