Re: [PATCH] document
Justin Pryzby <pryzby@telsasoft.com>
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Laurenz Albe <laurenz.albe@cybertec.at>, Ian Lawrence Barwick <barwick@gmail.com>, pgsql-hackers@postgresql.org
Date: 2021-08-25T16:39:59Z
Lists: pgsql-hackers
On Wed, Aug 25, 2021 at 09:50:13AM -0400, Tom Lane wrote: > Fujii Masao <masao.fujii@oss.nttdata.com> writes: > > When I applied the patch to the master, I found that the table entries for > > those function were added into the table for aclitem functions in the docs. > > I think this is not valid position and needs to be moved to the proper one > > (maybe the table for system catalog information functions?). > > You have to be very careful these days when applying stale patches to > func.sgml --- there's enough duplicate boilerplate that "patch' can easily > be fooled into dumping an addition into the wrong place. I doubt that > the submitter meant the doc addition to go there. I suppose one solution to this is to use git format-patch -U11 or similar, at least for doc/ Or write the "duplicate boilerplate" across fewer lines. And another is to add <!-- function() --> comments before and/or after each. -- Justin
Commits
-
doc: Document pg_encoding_to_char() and pg_char_to_encoding().
- f6b5d05ba9a4 15.0 landed
-
Add builtin functions:
- 5eb1d0deb15f 7.1.1 cited