Re: .ready and .done files considered harmful
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: bossartn@amazon.com
Cc: robertmhaas@gmail.com, dipesh.pandit@gmail.com,
jeevan.ladhe@enterprisedb.com, sfrost@snowman.net, andres@anarazel.de,
hannuk@google.com, pgsql-hackers@postgresql.org
Date: 2021-08-24T02:36:55Z
Lists: pgsql-hackers
(sigh..) At Tue, 24 Aug 2021 11:35:06 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in > > IIUC partial WAL files are handled because the next file in the > > sequence with the given TimeLineID won't be there, so we will fall > > back to a directory scan and pick it up. Timeline history files are > > handled by forcing a directory scan, which should work because they > > always have the highest priority. Backup history files, however, do > > not seem to be handled. I think one approach to fixing that is to > > also treat backup history files similarly to timeline history files. > > If one is created, we force a directory scan, and the directory scan > > logic will consider backup history files as higher priority than > > everything but timeline history files. > > Backup history files are (currently) just informational and they are > finally processed at the end of a bulk-archiving performed by the fast > path. However, I feel that it is cleaner to trigger a directory scan > every time we add an other-than-a-regular-WAL-file, as base-backup or - promotion are not supposed happen so infrequently. + promotion are not supposed happen so frequently. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Reduce overhead of renaming archive status files.
- 756e221db610 16.0 cited
-
Improve performance of pgarch_readyXlog() with many status files.
- beb4e9ba1652 15.0 landed
-
Prioritize history files when archiving
- b981df4cc09a 12.0 cited