Re: strange case of "if ((a & b))"

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2021-08-18T18:02:22Z
Lists: pgsql-hackers
On Thu, Jun 24, 2021 at 09:31:11PM -0500, Justin Pryzby wrote:
> On Wed, Apr 28, 2021 at 02:40:09PM -0400, Tom Lane wrote:
> > Justin Pryzby <pryzby@telsasoft.com> writes:
> > > These look strange to me - the inner parens don't do anything.
> > > I wouldn't write it with 2x parens for the same reason I wouldn't write it with
> > > 8x parens.
> > 
> > Agreed, but shouldn't we just drop the excess parens rather than
> > doubling down on useless notation?
> 
> I believe I got the impression from Michael that there was a style preference
> to write != 0.
> 
> 0002 is a bonus patch I found in my typos branch.  I will hold onto it for
> later if nobody wants to deal with it.

I am ready to deal with this patch.  Should I apply it to master soon?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.




Commits

  1. Clean up more code using "(expr) ? true : false"

  2. Clean up some code using "(expr) ? true : false"