Horton

Re: call popcount32/64 directly on non-x86 platforms

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: David Rowley <dgrowleyml@gmail.com>
Cc: John Naylor <john.naylor@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Amit Khandekar <amitdkhan.pg@gmail.com>
Date: 2021-08-12T14:33:58Z
Lists: pgsql-hackers 
On 2021-Aug-13, David Rowley wrote:

> Maybe you saw that there's no such equivalent test when we set
> HAVE_X86_64_POPCNTQ for MSVC on x86_64.  The reason for that is that
> we do the run-time test using cpuid.

Yeah, that and also I mistook the two independent "ifdef" blocks for one
block with an "#else".  Re-reading the ifdef maze, it looks reasonable.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/

Commits

  1. Use direct function calls for pg_popcount{32,64} on non-x86 platforms