Horton
Menu

Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data

Noah Misch <noah@leadboat.com>

View thread
From: Noah Misch <noah@leadboat.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-bugs@lists.postgresql.org
Date: 2021-07-23T22:30:21Z
Lists: pgsql-bugs 
On Fri, Jul 23, 2021 at 09:33:18PM +0500, Andrey Borodin wrote:
> > 21 июля 2021 г., в 22:55, Noah Misch <noah@leadboat.com> написал(а):
> > These drafts use reasonable concepts. Would you develop them into a
> > ready-to-commit patch?  You may be able to translate your probabilistic test
> > procedures from https://gist.github.com/x4m/8b6025995eedf29bf588727375014dfc
> > into something like the src/bin/pgbench/t/001_pgbench_with_server.pl test of
> > pg_enum_oid_index.
> 
> I'm working on it. Is it OK to use amcheck in pgbench tests? Or is it better to add the test to amcheck?

It could be okay, but I think it's better to add the test under amcheck.  You
could still use pgbench in the test.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve contrib/amcheck's tests for CREATE INDEX CONCURRENTLY.

  2. Fix minor memory leaks in pg_dump.

  3. Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY.

  4. Fix CREATE INDEX CONCURRENTLY for the newest prepared transactions.

  5. Add -w back to the flags for pg_ctl (re)start in PostgresNode

  6. Fix CREATE INDEX CONCURRENTLY for simultaneous prepared transactions.