Horton

Re: ERROR: "ft1" is of the wrong type.

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread View on postgr.es
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: peter.eisentraut@enterprisedb.com
Cc: michael@paquier.xyz, ahsan.hadi@gmail.com, pgsql-hackers@lists.postgresql.org
Date: 2021-07-09T01:44:13Z
Lists: pgsql-hackers

Attachments

At Thu, 8 Jul 2021 10:02:53 +0200, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote in 
> My patch is now committed.  The issue that started this thread now behaves
> like this:
> 
> ALTER TABLE ft1 ATTACH PARTITION ...;
> ERROR:  ALTER action ATTACH PARTITION cannot be performed on relation "ft1"
> DETAIL:  This operation is not supported for foreign tables.
> 
> So, for PG15, this is taken care of.

Cool.

> Backpatches under the old style for missing combinations would still be in
> scope, but there my comment on the proposed patches is that I would rather not
> remove apparently unused combinations from back branches.

Sounds reasonable. So the attached are that for PG11-PG14.  11 and 12
shares the same patch.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Fix unexpected error messages for various flavors of ALTER TABLE

  2. Revert per-index collation version tracking feature.

  3. Restructure ALTER TABLE execution to fix assorted bugs.