Re: strange case of "if ((a & b))"
Justin Pryzby <pryzby@telsasoft.com>
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-06-25T02:31:11Z
Lists: pgsql-hackers
Attachments
- 0001-Avoid-double-parens.patch (text/x-diff)
On Wed, Apr 28, 2021 at 02:40:09PM -0400, Tom Lane wrote: > Justin Pryzby <pryzby@telsasoft.com> writes: > > These look strange to me - the inner parens don't do anything. > > I wouldn't write it with 2x parens for the same reason I wouldn't write it with > > 8x parens. > > Agreed, but shouldn't we just drop the excess parens rather than > doubling down on useless notation? I believe I got the impression from Michael that there was a style preference to write != 0. 0002 is a bonus patch I found in my typos branch. I will hold onto it for later if nobody wants to deal with it.
Commits
-
Clean up more code using "(expr) ? true : false"
- 68f7c4b57a27 15.0 landed
-
Clean up some code using "(expr) ? true : false"
- fd0625c7a9c6 15.0 landed