Horton

Re: Improving isolationtester's data output

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers@lists.postgresql.org
Date: 2021-06-16T19:30:23Z
Lists: pgsql-hackers 
Hi,

On 2021-06-15 22:44:29 -0400, Tom Lane wrote:
> Here's a really quick-and-dirty patch to see what that would look
> like.  I haven't bothered here to update the expected-files outside
> the main src/test/isolation directory, nor to fix the variant files.

Neat.


> +	memset(&popt, 0, sizeof(popt));
> +	popt.header = true;
> +	popt.align = true;
> +	popt.fieldSep = "|";
> +	PQprint(stdout, res, &popt);
>  }

Is there an argument for not aligning because that can make diffs larger
than the actual data changes? E.g. one row being longer will cause all
rows in the result set to be shown as differing because of the added
padding?  This has been a problem in the normal regression tests, where
we solved it by locally disabling alignment. It might be unproblematic
for isolationtester, because we don't often have large result sets...

Greetings,

Andres Freund

Commits

  1. Improve display of query results in isolation tests.

  2. Detect unused steps in isolation specs and do some cleanup

  3. Remove dry-run mode from isolationtester