Horton

Re: Move pg_attribute.attcompression to earlier in struct for reduced size?

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Robert Haas <robertmhaas@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-06-04T23:21:11Z
Lists: pgsql-hackers

Attachments

On 2021-Jun-04, Tom Lane wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:

> > Now, while this patch does seem to work correctly, it raises a number of
> > weird cpluspluscheck warnings, which I think are attributable to the
> > new macro definitions.  I didn't look into it closely, but I suppose it
> > should be fixable given sufficient effort:
> 
> Didn't test, but the first one is certainly fixable by adding a cast,
> and I guess the others might be as well.

I get no warnings with this one.  I'm a bit wary of leaving
VARDATA_COMPRESSED_GET_EXTSIZE unchanged, but at least nothing in this
patch requires a cast there.

-- 
Álvaro Herrera       Valdivia, Chile

Commits

  1. Remove forced toast recompression in VACUUM FULL/CLUSTER

  2. Rethink definition of pg_attribute.attcompression.

  3. Fix memory leak when de-toasting compressed values in VACUUM FULL/CLUSTER

  4. Re-order pg_attribute columns to eliminate some padding space.

  5. Add more TAP tests for pg_dump with attribute compression