Horton

Re: Fixup some appendStringInfo and appendPQExpBuffer calls

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-02T10:57:01Z
Lists: pgsql-hackers 
On 2021-Jun-02, houzj.fnst@fujitsu.com wrote:

> Hi,
> 
> In the latest HEAD branch, I found some places were using
> appendStringInfo/appendPQExpBuffer() when they could have been using
> appendStringInfoString/ appendPQExpBufferStr() instead. I think we'd better
> fix these places in case other developers will use these codes as a reference,
> though, it seems will not bring noticeable performance gain.

hmm why didn't we get warnings about the PENDING DETACH one?  Maybe we
need some decorator in PQExpBuffer.


-- 
Álvaro Herrera                            39°49'30"S 73°17'W
"La espina, desde que nace, ya pincha" (Proverbio africano)

Commits

  1. Clean up some questionable usages of DatumGet* macros

  2. Standardize usages of appendStringInfo and appendPQExpBuffer