Re: Bracket, brace, parenthesis
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: michael@paquier.xyz
Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Date: 2021-05-28T06:25:40Z
Lists: pgsql-hackers
Attachments
At Thu, 27 May 2021 21:08:46 +0900, Michael Paquier <michael@paquier.xyz> wrote in > On Thu, May 27, 2021 at 03:20:10PM +0900, Kyotaro Horiguchi wrote: > > At Fri, 14 May 2021 10:04:57 -0400, Tom Lane <tgl@sss.pgh.pa.us> wrote in > >> +1. I tend to write "square bracket" or "curly brace" when I want to > >> be extra clear, but I think the bare terms are widely understood to > >> have those meanings. > > > > Thanks! I think the message is new in 14 so we can fix it right > > away. The attached is the version with a commit message added. > > No objections from me to fix that on HEAD now for clarity, let's wait > a bit and see if others have more comments. You have missed an update > of multirangetypes.out, by the way. Mmm. Thanks. So the test doesn't a check for the case of trailing garbage. Looking the discussion about trailing garbage of interger values, we might need one for the case. The atached second file adds a test for trailing garbage for multirangetype.sql and rangetype.sql. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Improve some error wording with multirange type parsing
- 12cc956664f1 14.0 landed