Re: Incorrect GUC descriptions in docs and postgresql.conf.sample
Justin Pryzby <pryzby@telsasoft.com>
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-05-26T02:01:30Z
Lists: pgsql-hackers
On Tue, May 25, 2021 at 08:43:14PM -0500, Justin Pryzby wrote:
> Your patch adds documentation about GUCs that can only be set at server
> start/config/commandline.
Oh: I realized that I read too quickly and misinterpretted what "only be set in
the config" means (I know I'm not the only one). Oops.
In some cases it sounds strange to say that a parameter can "only" be set in
the config file, since it's dynamically changed at runtime. Which is more
flexible than restrictive.
of a restriction.
> But it's not true for any of these, which are all HUP/SUSET.
> Please double check your logic :)
>
> src/backend/utils/misc/guc.c: {"autovacuum_work_mem", PGC_SIGHUP, RESOURCES_MEM,
> src/backend/utils/misc/guc.c: {"remove_temp_files_after_crash", PGC_SIGHUP, ERROR_HANDLING_OPTIONS,
> src/backend/utils/misc/guc.c: {"restart_after_crash", PGC_SIGHUP, ERROR_HANDLING_OPTIONS,
> src/backend/utils/misc/guc.c: {"log_lock_waits", PGC_SUSET, LOGGING_WHAT,
> src/backend/utils/misc/guc.c: {"autovacuum_work_mem", PGC_SIGHUP, RESOURCES_MEM,
> src/backend/utils/misc/guc.c: {"ssl_max_protocol_version", PGC_SIGHUP, CONN_AUTH_SSL,
> src/backend/utils/misc/guc.c: {"ssl_min_protocol_version", PGC_SIGHUP, CONN_AUTH_SSL,
--
Justin
Commits
-
doc: Fix description of some GUCs in docs and postgresql.conf.sample
- 521a812f0f5c 9.6.23 landed
- 9395672a52d6 10.18 landed
- b1a1f775bc90 11.13 landed
- 99d6dd3b4d94 12.8 landed
- 0ab64ab318f2 13.4 landed
- 2941138e60fc 14.0 landed