Re: Incorrect GUC descriptions in docs and postgresql.conf.sample

Justin Pryzby <pryzby@telsasoft.com>

From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-05-26T01:43:14Z
Lists: pgsql-hackers
Your patch adds documentation about GUCs that can only be set at server
start/config/commandline.

But it's not true for any of these, which are all HUP/SUSET.
Please double check your logic :)

src/backend/utils/misc/guc.c:           {"autovacuum_work_mem", PGC_SIGHUP, RESOURCES_MEM,
src/backend/utils/misc/guc.c:           {"remove_temp_files_after_crash", PGC_SIGHUP, ERROR_HANDLING_OPTIONS,
src/backend/utils/misc/guc.c:           {"restart_after_crash", PGC_SIGHUP, ERROR_HANDLING_OPTIONS,
src/backend/utils/misc/guc.c:           {"log_lock_waits", PGC_SUSET, LOGGING_WHAT,
src/backend/utils/misc/guc.c:           {"autovacuum_work_mem", PGC_SIGHUP, RESOURCES_MEM,
src/backend/utils/misc/guc.c:           {"ssl_max_protocol_version", PGC_SIGHUP, CONN_AUTH_SSL,
src/backend/utils/misc/guc.c:           {"ssl_min_protocol_version", PGC_SIGHUP, CONN_AUTH_SSL,

-- 
Justin



Commits

  1. doc: Fix description of some GUCs in docs and postgresql.conf.sample