Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: masao.fujii@oss.nttdata.com
Cc: pgsql-hackers@postgresql.org
Date: 2021-05-19T00:53:08Z
Lists: pgsql-hackers
At Tue, 18 May 2021 12:48:38 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in > Currently a promotion causes all available WAL to be replayed before > a standby becomes a primary whether it was in paused state or not. > OTOH, something like immediate promotion (i.e., standby becomes > a primary without replaying outstanding WAL) might be useful for > some cases. I don't object to that. Mmm. I was confused with recovery target + pause. Actually promotion works as so and it is documented. Anyway it is a matter of the next version. I forgot to mention the patch itself, but what the patch does looks fine to me. Disabling pause after setting SharedProteIsTriggered prevents later re-pausing (from the sql function). regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Remove unnecessary use of Time::HiRes from 013_crash_restart.pl.
- df466d30c6ca 14.0 landed
-
Add regression test for recovery pause.
- 6bbc5c5e96b0 14.0 landed
-
Make standby promotion reset the recovery pause state to 'not paused'.
- 167bd4804995 14.0 landed
-
Prefer standby promotion over recovery pause.
- 496ee647ecd2 13.0 cited