Re: Typo in README.barrier
Tatsuo Ishii <ishii@sraoss.co.jp>
From: Tatsuo Ishii <ishii@sraoss.co.jp>
To: dgrowleyml@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-05-16T13:29:30Z
Lists: pgsql-hackers
Attachments
- README.barrier_v2.diff (text/x-patch) patch v2
> Yeah looks like a typo to me. Ok. > I wonder if we also need to fix this part: > >> either one does their writes. Eventually we might be able to use an atomic >> fetch-and-add instruction for this specific case on architectures that support >> it, but we can't rely on that being available everywhere, and we currently >> have no support for it at all. Use a lock. > > That seems to have been written at a time before we got atomics. > > The following also might want to mention atomics too: > >> 2. Eight-byte loads and stores aren't necessarily atomic. We assume in >> various places in the source code that an aligned four-byte load or store is >> atomic, and that other processes therefore won't see a half-set value. >> Sadly, the same can't be said for eight-byte value: on some platforms, an >> aligned eight-byte load or store will generate two four-byte operations. If >> you need an atomic eight-byte read or write, you must make it atomic with a >> lock. Yes, we'd better to fix them. Attached is a propsal for these. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Commits
-
Fix typo and outdated information in README.barrier
- 943bda157eca 9.6.23 landed
- e71219ca11fa 10.18 landed
- a399755ba2fc 11.13 landed
- 898c62951e80 12.8 landed
- 010429eb1f77 13.4 landed
- 2ded19fa3a4d 14.0 landed