Horton

Re: compute_query_id and pg_stat_statements

Julien Rouhaud <rjuju123@gmail.com>

View thread View on postgr.es
From: Julien Rouhaud <rjuju123@gmail.com>
To: Maciek Sakrejda <m.sakrejda@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>, Pavel Stehule <pavel.stehule@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Magnus Hagander <magnus@hagander.net>, Fujii Masao <masao.fujii@oss.nttdata.com>, Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Stephen Frost <sfrost@snowman.net>, Christoph Berg <myon@debian.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-13T05:46:02Z
Lists: pgsql-hackers 
On Wed, May 12, 2021 at 10:31:01PM -0700, Maciek Sakrejda wrote:
> On Wed, May 12, 2021 at 9:58 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
> > Le jeu. 13 mai 2021 à 12:52, Maciek Sakrejda <m.sakrejda@gmail.com> a écrit :
> >>
> >> For what it's worth, I don't think the actual changing of an extra
> >> setting is that big a burden: it's the figuring out that you need to
> >> change it, and how you should configure it, that is the problem.
> >> Especially since all major search engines still seem to return 9.4 (!)
> >> documentation as the first hit for a "pg_stat_statements" search. The
> >> common case (installing pg_stat_statements but not tweaking query id
> >> generation) should be simple.
> >
> >
> > the v2 patch I sent should address both your requirements.
> 
> Yes, thanks--I just tried it and this is great. I just wanted to argue
> against reversing course here.

Oh ok.  Good news then, thanks!

Commits

  1. Allow compute_query_id to be set to 'auto' and make it default

  2. Move pg_stat_statements query jumbling to core.