Horton

Re: Why do we have perl and sed versions of Gen_dummy_probes?

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, pgsql-hackers@postgresql.org, Michael Paquier <michael@paquier.xyz>, Craig Ringer <craig.ringer@enterprisedb.com>
Date: 2021-05-11T19:53:06Z
Lists: pgsql-hackers

Attachments

On 2021-May-11, Andrew Dunstan wrote:

> Yeah, but this will create the perl file in the vpath directory where it
> won't ever be used anyway. You really want this back in the source
> directory where you can check it in etc.

Hmm ... no, it doesn't.  As far as I can see it works as intended.  The
path to the prolog file is broken, yes, but that's it.  However, maybe
I'm doing something wrong but if you define the rule like that, then it
no longer works in normal (non-vpath) mode.  This works:


-- 
Álvaro Herrera                            39°49'30"S 73°17'W

Commits

  1. Tweak generation of Gen_dummy_probes.pl

  2. Add a README and Makefile recipe for Gen_dummy_probes.pl

  3. Remove dependency on psed for MSVC builds.