Re: [PATCH] Identify LWLocks in tracepoints
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Craig Ringer <craig.ringer@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-05-10T16:46:02Z
Lists: pgsql-hackers
Hi, On 2021-05-10 12:14:46 -0400, Tom Lane wrote: > Andres Freund <andres@anarazel.de> writes: > > Looks like it did, but turned out to have some unintended side-effects > > :(. > > The snapshot builds are now new: > > https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=flaviventris&dt=2021-05-10%2015%3A43%3A56&stg=configure > > configure:3966: ccache /usr/lib/gcc-snapshot/bin/gcc --version >&5 > > gcc (Debian 20210421-1) 11.0.1 20210421 (prerelease) [gcc-11 revision fbb7739892e:d13ce34bd01:3756d99dab6a268d0d8a17583980a86f23f0595a] > > But the aforementioned dependencies that needed to remove broke the > > installed old versions of gcc/clang. > > I started to build the old versions of llvm manually, but that then hits > > the issue that at least 3.9 doesn't build with halfway modern versions > > of gcc/clang. So I gotta do it stepwise (i.e. go backwards, build llvm > > n-2 with n-1), will take a bit of time. > > Ugh. Memo to self: don't rag on other peoples' buildfarm configurations > right before a release deadline :-(. Sorry to cause you trouble. No worries - I knew that I'd have to do this at some point, even though I hadn't planned to do that today... I should have all of them green before end of today. I found that I actually can build LLVM 3.9 directly, as clang-6 can still build it directly (wheras the oldest gcc still installed can't build it directly). So it's a bit less painful than I thought at first The 3.9 instances (phycodurus, dragonet) tests are running right now, and I'm fairly sure they'll pass (most of a --noreport --nostatus run passed). Going forward building LLVM 4,5,6 now - the later versions take longer... Greetings, Andres Freund
Commits
-
Emit dummy statements for probes.d probes when disabled
- 0d204a4b09f7 13.3 landed
- fa8fbadb934b 14.0 landed
-
Prevent lwlock dtrace probes from unnecessary work
- e48ce7ef0ef8 13.3 landed
- b94409a02f61 14.0 landed
-
doc: Fix typo in logicaldecoding.sgml.
- 5fe83adad9ef 14.0 cited
-
Move lwlock-release probe back where it belongs
- 96ae658e6238 14.0 landed
-
Remove bogus tracepoint
- 09418bed67a7 14.0 landed
-
Simplify LWLock tranche machinery by removing array_base/array_stride.
- 3761fe3c20bb 10.0 cited
-
Improve LWLock scalability.
- ab5194e6f617 9.5.0 cited