Horton

Re: Small issues with CREATE TABLE COMPRESSION

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Dilip Kumar <dilipbalaut@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>, Jacob Champion <pchampion@vmware.com>
Date: 2021-05-08T13:22:39Z
Lists: pgsql-hackers 
On Sat, May 08, 2021 at 10:13:09PM +0900, Michael Paquier wrote:
> +      You need <productname>LZ4</productname>, if you want to support
> +      the compression of data with this method; see
> +      <xref linkend="sql-createtable"/>.

I suggest to change "the compression" to "compression".
I would write the whole thing like:
| The LZ4 library is needed to support compression of data using that method...

> +         Build with <productname>LZ4</productname> compression support.
> +         This allows the use of <productname>LZ4</productname> for the
> +         compression of table data.   

remove "the"

-- 
Justin

Commits

  1. Add support for LZ4 build in MSVC scripts

  2. Add more TAP tests for pg_dump with attribute compression

  3. doc: Fix some gaps with the documentation related to LZ4

  4. Fix incorrect error code for CREATE/ALTER TABLE COMPRESSION

  5. Additional doc fixes for configurable TOAST compression.

  6. docs: Clarify how ALTER TABLE .. SET COMPRESSION works.