Horton

Re: AlterSubscription_refresh "wrconn" wrong variable?

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-06T20:58:28Z
Lists: pgsql-hackers 
On 2021-May-06, Peter Smith wrote:

> PSA v3 of the patch. Same as before, but now also renames the global
> variable from "wrconn" to "lrep_worker_wrconn".

I think there are two patches here -- the changes to
AlterSubscription_refresh are a backpatchable bugfix, and the rest of it
can just be applied to master.

In my mind we make a bit of a distinction for global variables by using
CamelCase rather than undercore_separated_words.  There are plenty that
violate that "rule" of course, but ISTM that makes them stand more and
it's less likely we've made this mistake.  So I would name the variable
LogRepWALRcvConn or something like that.  My €0.02.

-- 
Álvaro Herrera       Valdivia, Chile
"Entristecido, Wutra                     (canción de Las Barreras)
echa a Freyr a rodar
y a nosotros al mar"

Commits

  1. Rename the logical replication global "wrconn"

  2. AlterSubscription_refresh: avoid stomping on global variable

  3. Logical replication support for initial data copy