Horton

Re: Enhanced error message to include hint messages for redundant options error

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-01T22:57:14Z
Lists: pgsql-hackers 
On 2021-May-01, Bharath Rupireddy wrote:

> IMO, it's not good to change the function API just for showing up
> parse_position (which is there for cosmetic reasons I feel) in an error
> which actually has the option name clearly mentioned in the error message.

Why not?  We've done it before, I'm sure you can find examples in the
git log.  The function API is not that critical -- these functions are
mostly only called from ProcessUtility and friends.

-- 
Álvaro Herrera                            39°49'30"S 73°17'W

Commits

  1. Improve reporting of "conflicting or redundant options" errors.

  2. Refactor function parse_subscription_options.