Horton

Re: TRUNCATE on foreign table

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, Kohei KaiGai <kaigai@heterodb.com>, Kazutaka Onishi <onishi@heterodb.com>, Amit Langote <amitlangote09@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, pgsql-hackers@lists.postgresql.org, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: 2021-04-22T17:34:37Z
Lists: pgsql-hackers 
On Thu, Apr 22, 2021 at 07:41:06AM -0700, Zhihong Yu wrote:
> > > > +  Note that <literal>ONLY</literal> option specified in
> > >
> > > add "the" to say: "the ONLY"
> >
> > +1.
> 
> Since 'the only option' is legitimate English phrase, I think the following
> would be clearer:
> 
> Note that the option <literal>ONLY</literal> ...

I think the ONLY option is better, more clear, and more consistent with the
rest of the documentation.

There are only ~5 places where we say "the option >OPTION<":
| git grep 'the option <' doc/src/sgml/

And at least 150 places where we say "The >OPTION< option" (I'm sure there are
some more which are split across lines).
| git grep -E 'the <([^>]*)>[^<]*</\1> option' doc/src/sgml/ |wc -l

-- 
Justin

Commits

  1. doc: Review for "Allow TRUNCATE command to truncate foreign tables".

  2. Don't pass "ONLY" options specified in TRUNCATE to foreign data wrapper.

  3. Support tab-complete for TRUNCATE on foreign tables.

  4. Allow TRUNCATE command to truncate foreign tables.

  5. Add support for asynchronous execution.