Horton

Re: TRUNCATE on foreign table

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Kohei KaiGai <kaigai@heterodb.com>, Kazutaka Onishi <onishi@heterodb.com>, Zhihong Yu <zyu@yugabyte.com>, Amit Langote <amitlangote09@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, pgsql-hackers@lists.postgresql.org, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: 2021-04-22T14:06:51Z
Lists: pgsql-hackers 
On Thu, Apr 22, 2021 at 05:09:02PM +0530, Bharath Rupireddy wrote:
> > should it say "specified" instead of requested ?
> > Or should it say "requested the RESTART IDENTITY behavior" ?
> >
> > Also, I think it should say "..otherwise, the CONTINUE IDENTITY behavior was
> > requested".
> 
> The original TRUNCATE document uses this - "When RESTART IDENTITY is specified"
> 
> IMO the following looks better: "If restart_seqs is true, RESTART
> IDENTITY was specified in the original TRUNCATE command, otherwise
> CONTINUE IDENTITY was specified."

This suggests that one of the two options was "specified", but the user maybe
didn't specify either, which is why we used the "behavior" language - if
neither is "specified" then the default behavior is what was "requested".

-- 
Justin

Commits

  1. doc: Review for "Allow TRUNCATE command to truncate foreign tables".

  2. Don't pass "ONLY" options specified in TRUNCATE to foreign data wrapper.

  3. Support tab-complete for TRUNCATE on foreign tables.

  4. Allow TRUNCATE command to truncate foreign tables.

  5. Add support for asynchronous execution.