Re: Possible typo/unclear comment in joinpath.c

Justin Pryzby <pryzby@telsasoft.com>

From: Justin Pryzby <pryzby@telsasoft.com>
To: James Coleman <jtc331@gmail.com>
Cc: pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-04-14T16:42:53Z
Lists: pgsql-hackers
On Wed, Apr 14, 2021 at 11:36:38AM -0400, James Coleman wrote:
> In joinpath.c three times we reference "extra_lateral_rels" (with
> underscores like it's a field), but as far as I can tell that's not a
> field anywhere in the source code, and looking at the code that
> follows it seems like it should be referencing "lateral_relids" (and
> the "extra" is really "extra [in relation to relids]").

It looks like a loose end from 

commit edca44b1525b3d591263d032dc4fe500ea771e0e
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date:   Mon Dec 7 18:56:14 2015 -0500

    Simplify LATERAL-related calculations within add_paths_to_joinrel().

-- 
Justin



Commits

  1. Fix obsolete comments referencing JoinPathExtraData.extra_lateral_rels.

  2. Simplify LATERAL-related calculations within add_paths_to_joinrel().