Horton

Re: BUG #16931: source code problem about commit_ts

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: zoulx1982@163.com, pgsql-bugs@lists.postgresql.org
Date: 2021-04-09T22:42:41Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove leftover dead code from commit_ts.h.

  2. Remove COMMIT_TS_SETTS record.

  3. Fix bug in WAL replay of COMMIT_TS_SETTS record.

On 2021-Mar-24, Fujii Masao wrote:

> diff --git a/src/backend/access/rmgrdesc/committsdesc.c b/src/backend/access/rmgrdesc/committsdesc.c
> index 7ebd3d35ef..26bad44b96 100644
> --- a/src/backend/access/rmgrdesc/committsdesc.c
> +++ b/src/backend/access/rmgrdesc/committsdesc.c
> @@ -38,31 +38,6 @@ commit_ts_desc(StringInfo buf, XLogReaderState *record)
>  		appendStringInfo(buf, "pageno %d, oldestXid %u",
>  						 trunc->pageno, trunc->oldestXid);
>  	}
> -	else if (info == COMMIT_TS_SETTS)

You have not pushed this one, right?  I think we should do it now.

Thanks

-- 
Álvaro Herrera                            39°49'30"S 73°17'W