Re: [PATCH] force_parallel_mode and GUC categories

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2021-04-09T11:39:28Z
Lists: pgsql-hackers, pgsql-performance
On Thu, Apr  8, 2021 at 10:17:18PM -0500, Justin Pryzby wrote:
> On Fri, Apr 09, 2021 at 10:50:53AM +0900, Michael Paquier wrote:
> > On Sat, Apr 03, 2021 at 08:25:46PM -0500, Justin Pryzby wrote:
> > > Forking this thread
> > > https://www.postgresql.org/message-id/20210403154336.GG29125%40momjian.us
> > 
> > Didn't see this one, thanks for forking.
> > 
> > -       {"force_parallel_mode", PGC_USERSET, QUERY_TUNING_OTHER,
> > +       {"force_parallel_mode", PGC_USERSET, DEVELOPER_OPTIONS,
> > And not this one either, as it is mainly a planner thing, like the
> > other parameters in the same area.
> 
> This is the main motive behind the patch.
> 
> Developer options aren't shown in postgresql.conf.sample, which it seems like
> sometimes people read through quickly, setting a whole bunch of options that
> sound good, sometimes including this one.  And in the best case they then ask
> on -performance why their queries are slow and we tell them to turn it back off
> to fix their issues.  This changes to no longer put it in .sample, and calling
> it a "dev" option seems to be the classification and mechanism by which to do
> that.

+1

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.




Commits

  1. Sync guc.c and postgresql.conf.sample with the SGML docs.

  2. doc: Move force_parallel_mode to section for developer options

  3. Move log_autovacuum_min_duration into its correct sections