Re: Additional Chapter for Tutorial - arch-dev.sgml
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Jürgen Purtz <juergen@purtz.de>
Cc: David Steele <david@pgmasters.net>, Heikki Linnakangas <hlinnaka@iki.fi>, Erik Rijkers <er@xs4all.nl>, "David G. Johnston" <david.g.johnston@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Justin Pryzby <pryzby@telsasoft.com>
Date: 2021-04-04T17:02:48Z
Lists: pgsql-hackers, pgsql-docs
On 2021-Apr-04, Jürgen Purtz wrote: > The small patch 'arch-dev.sgml.20210121.diff' contains only some clearing up > concerning the used terminology and its alignments with the glossary. The > patch was rejected by Heikki. This comment is not helpful, because it's not obvious where would I find that patch. Also, you say "the patch was rejected by Heikki" but upthread he said he committed it. His comment was that he left out some paragraphs because of a style issue. Did you re-post that patch after fixing the style issues? If you did, I couldn't find it. > The latest version of the huge patch '0013-architecture.patch' is valid and > doesn't contain merge conflicts. Yeah, OK, but I have to dive deep in the thread to find it. Please post it again. When you have a patch series, please post it as a whole every time -- that makes it easier for a committer to review it. You seem to be making your life hard by not using git to assist you. Do you know you can have several commits in a branch of your own, rebase it to latest master, merge master to it, rebase on top of master, commit fixups, "rebase -i" and change commit ordering to remove unnecessary fixup commits, and so on? Such techniques are extremely helpful when dealing with a patch series. When you want to post a new version to the list, you can just do "git format-patch -v14 origin/master" to produce a set of patch files. You don't need to manually give names to your patch files, or come up with a versioning scheme. Just increment the argument to -v by +1 each time you (or somebody else) posts a new version of the patch series. -- Álvaro Herrera Valdivia, Chile
Commits
-
Align some terms in arch-dev.sgml to glossary
- 6734e806958c 14.0 landed
-
doc: Copy-edit the "Overview of PostgreSQL Internals" chapter
- 29ad6595ef7f 14.0 landed
-
Merge postmaster and postgres command into just postgres. postmaster
- 5266f221a2e1 8.2.0 cited