Horton

Thread

Commits

  1. Refactor logic to check for ASCII-only characters in string

  1. Refactor routine to check for ASCII-only case

    Michael Paquier <michael@paquier.xyz> — 2020-12-18T03:57:12Z

    Hi all,

As mentioned in [1], there are three places where there is the same
routine to check if a string is made only of ASCII characters.

This makes for a small-ish but nice cleanup, as per the attached.

Thanks,

[1]: https://www.postgresql.org/message-id/X9lVLGRuG0hTHrVo@paquier.xyz
--
Michael

  2. Re: Refactor routine to check for ASCII-only case

    Heikki Linnakangas <hlinnaka@iki.fi> — 2020-12-18T09:54:24Z

    On 18/12/2020 05:57, Michael Paquier wrote:
> As mentioned in [1], there are three places where there is the same
> routine to check if a string is made only of ASCII characters.
> 
> This makes for a small-ish but nice cleanup, as per the attached.

+1

- Heikki

  3. Re: Refactor routine to check for ASCII-only case

    Stephen Frost <sfrost@snowman.net> — 2020-12-18T16:30:16Z

    Greetings,

* Heikki Linnakangas (hlinnaka@iki.fi) wrote:
> On 18/12/2020 05:57, Michael Paquier wrote:
> >As mentioned in [1], there are three places where there is the same
> >routine to check if a string is made only of ASCII characters.
> >
> >This makes for a small-ish but nice cleanup, as per the attached.
> 
> +1

Yeah, in a quick look, this looks like a good improvement.

Thanks,

Stephen

  4. Re: Refactor routine to check for ASCII-only case

    Michael Paquier <michael@paquier.xyz> — 2020-12-21T00:44:30Z

    On Fri, Dec 18, 2020 at 11:30:16AM -0500, Stephen Frost wrote:
> * Heikki Linnakangas (hlinnaka@iki.fi) wrote:
>> +1
> 
> Yeah, in a quick look, this looks like a good improvement.

Thanks.  This has been applied as of 93e8ff8.
--
Michael