Horton

Re: pg_dump, ATTACH, and independently restorable child partitions

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, David Rowley <drowley@postgresql.org>, pgsql-hackers@lists.postgresql.org
Date: 2020-12-04T18:02:31Z
Lists: pgsql-hackers

Attachments

On Fri, Dec 04, 2020 at 12:13:05PM -0500, Tom Lane wrote:
> Justin Pryzby <pryzby@telsasoft.com> writes:
> > [ v4-0001-pg_dump-output-separate-object-for-ALTER-TABLE.AT.patch ]
> 
> The cfbot is being picky about this:
> 
> 3218pg_dump.c: In function ‘dumpTableAttach’:
> 3219pg_dump.c:15600:42: error: suggest parentheses around comparison in operand of ‘&’ [-Werror=parentheses]
> 3220  if (attachinfo->partitionTbl->dobj.dump & DUMP_COMPONENT_DEFINITION == 0)
> 3221                                          ^
> 3222cc1: all warnings being treated as errors
> 
> which if I've got the precedence straight is indeed a bug.

Oops - from a last-minute edit.
I missed it due to cfboot being slow, and clogged up with duplicate entries.
This also adds/updates comments.

-- 
Justin

Commits

  1. pg_dump: label INDEX ATTACH ArchiveEntries with an owner.

  2. Dump ALTER TABLE ... ATTACH PARTITION as a separate ArchiveEntry.

  3. Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (reprise)