Re: Tab complete for CREATE OR REPLACE TRIGGER statement

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "Shinoda, Noriyoshi (PN Japan FSI)" <noriyoshi.shinoda@hpe.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2020-11-17T02:55:35Z
Lists: pgsql-hackers
On Mon, Nov 16, 2020 at 09:14:51PM -0500, Tom Lane wrote:
> It's kind of depressing how repetitive the patch is.  There's
> probably not much to be done about that in the short run, but
> it seems to point up the need to start thinking about how to
> refactor tab-complete.c more thoroughly.

Agreed.  One thing that I'd think could help is a new wild card to
make some of the words conditional in the list of items.  But that may
be tricky once you consider the case of a group of words.

I don't think that this is a requirement for this thread, though.
--
Michael

Commits

  1. Add tab completion for CREATE [OR REPLACE] TRIGGER in psql