Horton

Re: pg_upgrade analyze script

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Magnus Hagander <magnus@hagander.net>, Georgios Kokolatos <gkokolatos@protonmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2020-11-11T01:21:27Z
Lists: pgsql-hackers

Attachments

On Tue, Nov 10, 2020 at 10:21:04AM +0900, Michael Paquier wrote:
> On Mon, Nov 09, 2020 at 03:47:22PM +0100, Peter Eisentraut wrote:
>> You should just remove those calls.  There is no need to replace them with
>> vacuumdb calls.  The reason those calls were there is that they were testing
>> the generated script itself.  If the script is gone, there is no more need.
>> There are already separate tests for testing vacuumdb.
> 
> True, 102_vacuumdb_stages.pl already does all that.

Let's fix that.  From what I can see it only involves the attached,
and as a bobus it also reduces the number of extra characters showing
on my terminal after running pg_upgrade tests.
--
Michael

Commits

  1. Remove vacuumdb --analyze-in-stages from pg_upgrade tests

  2. Remove analyze_new_cluster script from pg_upgrade