Re: abstract Unix-domain sockets
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-11-10T06:24:31Z
Lists: pgsql-hackers
On Mon, Nov 09, 2020 at 09:04:24AM +0100, Peter Eisentraut wrote: > On 2020-11-09 07:08, Michael Paquier wrote: > The @ is the standard way of representing this in the user interface and the > configuration, so it seems sensible to me that way. Ok. > Can you sketch how you would structure this? I realize it's not very > elegant, but I couldn't come up with a better way that didn't involve having > to duplicate some of the error messages into multiple branches. I think that I would use a StringInfo to build each sentence of the hint separately. The first sentence, "Is another postmaster already running on port %d?" is already known. Then the second sentence could be built depending on the two other conditions. FWIW, I think that it is confusing to mention in the hint to remove a socket file that cannot be removed. -- Michael
Commits
-
Add support for abstract Unix-domain sockets
- c9f0624bc2f5 14.0 landed
-
Make error hint from bind() failure more accurate
- d5d91acdccae 14.0 landed
-
Remove obsolete ifdefs
- 555eb1a4f011 14.0 landed