Horton

Re: Yet another (minor) fix in BRIN

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-11-08T01:51:37Z
Lists: pgsql-hackers 
On 2020-Nov-08, Tomas Vondra wrote:

> While rebasing some of the BRIN patches, I noticed some of the code in
> brin_memtuple_initialize is duplicated. This happened in 8bf74967dab
> which moved some of the code from brin_new_memtuple, not removing the
> shared pieces. In practice this is benign, of course.
> 
> Barring objections I'll get the attached fix committed and backpatched.

LGTM, thanks for noticing.

Commits

  1. Remove duplicate code in brin_memtuple_initialize