Re: redundant error messages
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Isaac Morland <isaac.morland@gmail.com>
Cc: Euler Taveira <euler.taveira@2ndquadrant.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-11-05T15:53:56Z
Lists: pgsql-hackers
On 2020-Nov-05, Isaac Morland wrote: > In principle, the client knows the database name. In practice, if it's > coming from PGDATABASE or via a service configuration, one may be confused > about the database; having the error message be explicit will avoid many > problems. I can easily imagine that "unable to connect to database" would > be mystifying, whereas "unable to connect to database foo" would elicit the > response, "wait, I'm trying to connect to what now?" leading much more > quickly to a resolution. Also consider cases like running something via cron, where the person reading the error output does not necessarily know what command is being run: it might be hidden inside a script. It's often very helpful to have object names in error messages, even if for the normal usage it seems that the object being operated on is very obvious by just looking at the command.
Commits
-
Fix redundant error messages in client tools
- 6be725e70161 14.0 landed
- f3ad4fddfaf7 13.1 landed
- 24bbdaa6feac 9.5.24 landed
- 8096be26178b 9.6.20 landed
- 468bed27ce8d 10.15 landed
- 42c088be1889 11.10 landed
- 16eadc4695ef 12.5 landed