Re: Dereference before NULL check (src/backend/storage/ipc/latch.c)
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: ranier.vf@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Date: 2020-11-02T00:49:47Z
Lists: pgsql-hackers
At Sat, 31 Oct 2020 11:40:53 -0300, Ranier Vilela <ranier.vf@gmail.com> wrote in > Hi, > > Per Coverity. > > If test set->latch against NULL, is why it can be NULL. > ResetEvent can dereference NULL. If the returned event is WL_LATCH_SET, set->latch cannot be NULL. We shouldn't inadvertently ignore the unexpected or broken situation.We could put Assert instead, but I think that we don't need do something here at all since SIGSEGV would be raised at the right location. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Fix WaitLatch(NULL) on Windows.
- a7e65dc88b6f 14.0 landed