Horton

Re: Consistent error reporting for encryption/decryption in pgcrypto

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Georgios Kokolatos <gkokolatos@protonmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2020-10-31T01:03:49Z
Lists: pgsql-hackers 
On Fri, Oct 30, 2020 at 11:23:27PM +0100, Daniel Gustafsson wrote:
> > On 30 Oct 2020, at 16:54, Georgios Kokolatos <gkokolatos@protonmail.com> wrote:
> 
> > I did notice that the cfbot [1] is not failing for this patch.
> 
> I assume you mean s/failing/passing/?  I noticed the red Travis and Appveyor
> runs, will fix over the weekend.  Thanks for the heads-up.

It seems to me that you are just missing to declare a new error number
in px.h, so I would suggest to just use -19.
--
Michael

Commits

  1. Add error code for encryption failure in pgcrypto

  2. Fix combo_decrypt() to throw an error for zero-length input when using a