Horton

Re: duplicate function oid symbols

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: John Naylor <john.naylor@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-10-28T19:28:40Z
Lists: pgsql-hackers 
On 2020-10-28 15:24:20 -0400, Tom Lane wrote:
> Nah.  What I'm imagining is just that pg_type.h contains
> 
> #ifdef EXPOSE_TO_CLIENT_CODE
> 
> /*
>  * Backwards compatibility for ancient random spellings of OID macros.
>  * Don't use these macros in new code.
>  */
> #define CASHOID  MONEYOID
> #define LSNOID   PG_LSNOID
> 
> #endif

Ah, good idea. +1


> We don't need to complicate genbki.pl with a new facility.

I assume you plan to error out if oid_symbol is defined for pg_type
going forward?

Commits

  1. Don't use custom OID symbols in pg_type.dat, either.

  2. Don't use custom OID symbols in pg_proc.dat.