Re: BUG #16688: psql removes only LF without CR at end of backquotes on windows.

On Tue, Oct 27, 2020 at 11:27:05PM -0400, Tom Lane wrote:
> PG Bug reporting form <noreply@postgresql.org> writes:
> > psql removes only LF without CR at end of backquotes on windows.
> 
> Hmm, seems like b654714f9 missed this.  psqlscanslash.l has
> 
>     fd = popen(cmd, PG_BINARY_R);
>     ...
>         /* strip any trailing newline */
>         if (cmd_output.len > 0 &&
>             cmd_output.data[cmd_output.len - 1] == '\n')
>             cmd_output.len--;
> 
> But rather than mess with that newline-chomping code, I'm
> inclined to wonder why we're using PG_BINARY_R for input
> that we clearly expect to be textual.  Most of our other
> popen's do not do that.
> 
> Bruce, this seems to date to 98e9775a3 ... don't suppose
> you remember that?  I see the point about control-Z in text
> files, but I wonder how plausible that is for popen cases.

It seems safe for popen to use TEXT mode, and it might help with
encoding conversion.  I don't think I made a popen distinction when I
was working in this area.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee