Re: pgsql: Restore replication protocol's duplicate command tags

Alvaro Herrera <alvherre@alvh.no-ip.org>

From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-10-15T12:52:21Z
Lists: pgsql-hackers
On 2020-Oct-15, Amit Kapila wrote:

> On Thu, Oct 15, 2020 at 6:07 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> > On 2020-Oct-14, Alvaro Herrera wrote:

> > Hm, this failed on sidewinder.
> 
> Now, curculio [1] also seems to be failing for the same reason.

Yeah ... and now they're both green.  Anyway clearly the test is
unstable.

> For the initial table sync, we use below in some of the tests (see
> 001_rep_changes):

Ah yeah, thanks, this should work.  Pushed, we'll see how it goes.

Thanks,



Commits

  1. Fix query in new test to check tables are synced

  2. Restore replication protocol's duplicate command tags

  3. Fix bogus completion tag usage in walsender